Hello,
is this the proper way to shrink a node and remove it using attribute animation?
[code]void MyComponent::ShrinkAndRemove()
{
ValueAnimation* anim{ new ValueAnimation{ context_ } };
anim->SetKeyFrame(0.0f, Vector3{ 1.0f, 1.0f, 1.0f });
anim->SetKeyFrame(0.5f, Vector3{ 0.2f, 0.2f, 0.2f });
anim->SetEventFrame(0.51f, E_SHRUNK);
GetNode()->SetAttributeAnimation("Scale", anim, WM_ONCE);
SubscribeToEvent(GetNode(), E_SHRUNK, URHO3D_HANDLER(MyComponent, HandleShrunk));
}
void MyComponent::HandleShrunk(StringHash eventType, VariantMap& eventData)
{
GetNode()->Remove();
}[/code]
I am asking because I need two patches to get it working.
[size=150]Problem 1[/size]
The event does not fire when time > 0.5. I traced the problem down to ValueAnimation::SetEventFrame(), where the begin/end times are not updated, unlike what happens in SetKeyFrame:
[code]bool ValueAnimation::SetKeyFrame(float time, const Variant& value)
{
…
beginTime_ = Min(time, beginTime_);
endTime_ = Max(time, endTime_);
splineTangentsDirty_ = true;
return true;
}
void ValueAnimation::SetEventFrame(float time, const StringHash& eventType, const VariantMap& eventData)
{
VAnimEventFrame eventFrame;
eventFrame.time_ = time;
eventFrame.eventType_ = eventType;
eventFrame.eventData_ = eventData;
if (eventFrames_.Empty() || time >= eventFrames_.Back().time_)
eventFrames_.Push(eventFrame);
else
{
for (unsigned i = 0; i < eventFrames_.Size(); ++i)
{
if (time < eventFrames_[i].time_)
{
eventFrames_.Insert(i, eventFrame);
break;
}
}
}
// ****** NOTHING HERE?? ******
}[/code]
Copying the three lines from SetKetFrame() solved the problem.
[size=150]Problem 2[/size]
I am getting a crash inside Animatable::UpdateAttributeAnimations() just after my event handler is called (in the same loop):
[code]void Animatable::UpdateAttributeAnimations(float timeStep)
{
if (!animationEnabled_)
return;
SharedPtr<Animatable> self(this); // ****** PATCH
Vector<String> finishedNames;
for (HashMap<String, SharedPtr<AttributeAnimationInfo> >::ConstIterator i = attributeAnimationInfos_.Begin();
i != attributeAnimationInfos_.End(); ++i)
{
if (i->second_->Update(timeStep))
finishedNames.Push(i->second_->GetAttributeInfo().name_); // ****** CRASH HERE
}
for (unsigned i = 0; i < finishedNames.Size(); ++i)
SetAttributeAnimation(finishedNames[i], 0);
}[/code]
The debugger shows the Animatable “this” pointer is invalid at that point because Node::Remove() deletes the node as well (no references left). So, I added the ugly line above to keep it alive.
