Archive 17/01/2023.

Replace XML parser

smellymumbler

How easy it is to replace the existing XML parser with any other format? I mean, i intend to use something like https://github.com/mayah/tinytoml or https://github.com/jbeder/yaml-cpp, but i want to know if there’s a common file-loading interface or any documentation on that.

Sinoid

There’s nothing that’s top-level shared. Binary, XML, and JSON are each their own separate paths.

It’s just a matter of the volume of work. As long as you support Variant, then the Node, UI, and Component derived types are little effort. However, there’s a fair bit going on with techniques, texture XML config, materials, particle effects, etc that will require much more work. Probably quite a bit in Urho2D as well.

It adds up to an awful lot of possible paths to test and confirm.

smellymumbler

github.com

urho3d/Urho3D/blob/master/Source/Urho3D/Scene/Scene.cpp#L190


}



bool Scene::LoadJSON(const JSONValue& source, bool setInstanceDefault)

{

URHO3D_PROFILE(LoadSceneJSON);



StopAsyncLoading();



// Load the whole scene, then perform post-load if successfully loaded

// Note: the scene filename and checksum can not be set, as we only used an XML element

if (Node::LoadJSON(source, setInstanceDefault))

{

    FinishLoading(nullptr);

    return true;

}

else

    return false;

}



void Scene::MarkNetworkUpdate()

{

Hmm, so each class is responsible for defining how it is created via any serialized format. Would you guys accept some sort of PR that changes this? I mean, IMHO, having a Parser interface that JSON and XML can implement, with factory methods responsible for creating the objects, would allow developers to choose any format or easily develop their own (or even switch the parser, like from Pugi to RapidXML).