Archive 17/01/2023.

Is there a ScopeGuard available in Urho3D

ricab

Is there any kind of ScopeGuard or ScopeExit available in Urho3D?

Here is a use case:

urho3d/Urho3D/blob/master/Source/Urho3D/Resource/Image.cpp#L976


int width, height;
unsigned components;
unsigned char* pixelDataIn = GetImageData(source, width, height, components);
if (!pixelDataIn)
{
    URHO3D_LOGERROR("Could not load image " + source.GetName() + ": " + String(stbi_failure_reason()));
    return false;
}
if (components != 3)
{
    URHO3D_LOGERROR("Invalid image format, can not load image");
    return false;
}


SetSize(COLOR_LUT_SIZE, COLOR_LUT_SIZE, COLOR_LUT_SIZE, components);
SetMemoryUse(width_ * height_ * depth_ * components);


unsigned char* pixelDataOut = GetData();


for (int z = 0; z < depth_; ++z)
{

There is a leak there (coverity 126870): FreeImageData(pixelDataIn); should be called on this exit path. While it could be called directly, a scope guard would be preferable, as it would avoid the duplicate function call and cover all possible [even future] exit branches.

Alternatively, Urho’s smart pointers could support custom deleters, but that would be more work.

weitjong

Alas, our SharedPtr is not a generic container. It can only contain Urho’s own refcounted object. Eugene has a PR which proposes a more generic container ala non-refcounted. But I don’t think it has ctor that takes a high-level function or lambda as deleter (yet). So at the moment, just do with what we got first, fixing it the old fashion way.

ricab

It’s been a while and just want to clarify that I’m currently unable to progress with any coverity issues because the service is down. It has been so since Feb 20 according to their twitter page

weitjong

Yes. It takes unusual long for them to fix the SSL server certificate issue or whatever. We are forced to temporarily remove the coverity scan badge from our README page as the result.