Bool cbuffer problem in DX11

Hi,
I encountered shader parameter problem, maybe it is not the root cause, just want to share my observation and ask for comment.

The problem is when I port outline shader to 2nd scene, the outline is always enabled, but 1st scene works fine.
I eventually get to Graphics::SetShaderParameter(StringHash param, bool value) in D3D11Graphics.cpp.
It seems the “buffer” will be overwritten and overwritten during drawing batches and batches, so the initial value of the bool cbuffer is a dirty value.

The code only set 1 byte while the cbuffer actually holds 4 bytes.

A quick dirty fix can fix the problem on my side.

Not sure this is the right place to fix, any comment is welcome, thank you.

Your compiler has a concept that a native boolean can be represented using a single byte in memory - this is a compiler optimization. When the parameter is sent to the shader, it uses a function provided by the underlying graphics api - in your case, DirectX. The translation of the native type to the shader type is meant to be handled by the local graphics api runtime. Any issues with transforming native system values to shader types, and particularly the primitives like bool, are likely to be driver issues, as this is outside of the scope of Urho3D - strictly speaking, urho uses graphics api to pass typed values, it’s not Urho’s fault if the shader is misinterpreting them. At least, if it is, I am very interested.